It’s never too late to change… right?
July 26th, 2007
When is it too late to change? When do you go back and change the design so that it’s more correct and more efficient rather than just leaving the code as it is in its working state? When do you go back and change all the controls so that they’re consistent rather than just leaving them as they are? When do you go back and fix the spaghetti code and when do you just let things continue to work?
I like things to be consistent throughout all my code and all my screens. I don’t like duplicated code. Sometimes at work I take things a bit too far and I go through all the code and change these things even though it may not be the most important thing at the moment.

Although there’s definitely a fine line on when you should do this. It’s a balancing act between what you get back and the time it takes to make the change. ROI, baby. Usually if I can make the change in about a day, it’s something that will help the overall design and if there’s low risk that my change will cause any bugs or failures then I’ll just make the change and be done with it.
But if the change isn’t particularly that important, then however much I feel the need to make the dialogs more consistent or to make all the classes use the same set of functionality then I try to restrain myself.
…So when do you make the change and when do you just let things be?





[…] hate reinventing the wheel every time I do a project for school, in the same way that I hate seeing duplicate code in stuff I’m working with on the job. If we never stand on the shoulders of giants… […]
December 21, 2007 @ 11:26 pm
[…] We never want users to have to guess how our dialogs work. It should be blatantly obvious. If that’s difficult or even impossible to do, at the very least make the dialogs in your application behave and look consistent. That’s the number one thing I preach to others and try to do myself. […]
December 21, 2007 @ 11:31 pm
[…] blogged about how important consistency is. Well, here is yet another […]
December 21, 2007 @ 11:34 pm